Do not build Docker image for fork PRs #17370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
reviewed
Apr 21, 2020
sampaiodiego
changed the title
sampaiodiego
changed the title
Member
Author
|
@rodrigok I've updated the PR with two possible solutions:
|
rodrigok
approved these changes
Jun 17, 2020
ggazzo
added a commit
that referenced
this pull request
Jun 18, 2020
…apps_rewrite* 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits) [IMPROVE] Performance editing Admin settings (#17916) [IMPROVE] React hooks lint rules (#17941) [FIX] StreamCast stream to server only streamers (#17942) [FIX] Profile save button not activates properly when changing the username field (#16541) [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830) [FIX] Links being escaped twice leading to visible encoded characters (#16481) [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550) [FIX] Message action popup doesn't adjust itself on screen resize (#16508) [FIX] Not possible to translate the label of custom fields in user's Info (#15595) [FIX] Close the user info context panel does not navigate back to the user's list (#14085) [FIX] Missing pinned icon indicator for messages pinned (#16448) Chatpal: limit results to current room (#17718) Do not build Docker image for fork PRs (#17370) [IMPROVE] Use REST for DDP calls by default (#17934) [IMPROVE] Add rate limiter to UiKit endpoints (#17859) LingoHub based on develop (#17796) [IMPROVE] Change default upload settings to only block SVG files (#17933) Update Dockerfile to not depend on custom base image (#17802) [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839) [FIX] Undesirable message updates after user saving profile (#17930) ...
gabriellsh
added a commit
that referenced
this pull request
Jun 18, 2020
…into new/apps_rewrite_local * 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat: (30 commits) Sort imports Move sidebar items registration Embed useMenuOptions into AppMenu Fix route redirection Fix lint errors Fix infinite loop in CodeSettingInput Fix spacing in What Is It page [IMPROVE] Performance editing Admin settings (#17916) [IMPROVE] React hooks lint rules (#17941) [FIX] StreamCast stream to server only streamers (#17942) [FIX] Profile save button not activates properly when changing the username field (#16541) [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830) [FIX] Links being escaped twice leading to visible encoded characters (#16481) [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550) [FIX] Message action popup doesn't adjust itself on screen resize (#16508) [FIX] Not possible to translate the label of custom fields in user's Info (#15595) [FIX] Close the user info context panel does not navigate back to the user's list (#14085) [FIX] Missing pinned icon indicator for messages pinned (#16448) Chatpal: limit results to current room (#17718) Do not build Docker image for fork PRs (#17370) ...
ggazzo
added a commit
that referenced
this pull request
Jun 18, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits) [FIX] Typo "coorosponding" (#17840) Regression: Infinite loop in CodeSettingInput (#17949) [NEW][ENTERPRISE] Download engagement data (#17920) [FIX] Hide system message add/remove owner (#17938) [IMPROVE] Performance editing Admin settings (#17916) [IMPROVE] React hooks lint rules (#17941) [FIX] StreamCast stream to server only streamers (#17942) [FIX] Profile save button not activates properly when changing the username field (#16541) [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830) [FIX] Links being escaped twice leading to visible encoded characters (#16481) [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550) [FIX] Message action popup doesn't adjust itself on screen resize (#16508) [FIX] Not possible to translate the label of custom fields in user's Info (#15595) [FIX] Close the user info context panel does not navigate back to the user's list (#14085) [FIX] Missing pinned icon indicator for messages pinned (#16448) Chatpal: limit results to current room (#17718) Do not build Docker image for fork PRs (#17370) [IMPROVE] Use REST for DDP calls by default (#17934) [IMPROVE] Add rate limiter to UiKit endpoints (#17859) LingoHub based on develop (#17796) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also frees disk space to prevent no space left errors for PRs not from forks.
I've ended up with two different solution for this issue:
build-image-prsteps if a secret is not available (the only condition I could find to determine if the PR is from a fork). this is the final yaml filebuild-image-prwill look like it have run and passed but the actual docker image will be not there to usedocker imagebut I think we should find a better name)